svelte: Port Placeholder component from Ember.js app
#12562
Merged
+83
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eth3lbert
approved these changes
Dec 21, 2025
Comment on lines
17
to
19
| <Placeholder style="width: 100%; height: 20px; border-radius: 4px;" /> | ||
| <Placeholder style="width: 80%; height: 20px; border-radius: 4px;" /> | ||
| <Placeholder style="width: 90%; height: 20px; border-radius: 4px;" /> |
Contributor
There was a problem hiding this comment.
Based on the example shown, if this scenario is common, I'd prefer providing props or CSS variables over an inline style approach.
Member
Author
There was a problem hiding this comment.
I've checked the current Ember.js usage and there we use class to set the width, height, margins, opacity, and border-radius.
I've added width, height, opacity and radius props now. margins and other stuff like that should still be set from outside the component IMHO.
Turbo87
force-pushed
the
svelte-placeholder
branch
from
21c70c4 to
4fcaf3a
Compare
Turbo87
force-pushed
the
svelte-placeholder
branch
from
4fcaf3a to
1cb72b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related